-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ossl config: shareable when frozen #809
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NCONF
is not a reference counted object, and is used in only one location outside ossl_config.c
, in ossl_x509ext.c
. It seems read-only.
This looks good to merge, once we've defined RUBY_TYPED_FROZEN_SHAREABLE
on older Ruby versions (#808).
827bf9c
to
7beda12
Compare
@rhenium done |
Could you add a test case for this class, too? |
fd3b246
to
33be1ef
Compare
@rhenium added test. FWIW I couldn't make the config frozen when initialized, as that interferes with |
I think it's acceptable that a I think making |
33be1ef
to
0535fb8
Compare
managed to make it frozen when initialized. turns out that |
It seems strange to me that I think making it shareable between ractors and making it frozen by default are two separate changes even if both make sense. Can you split them into two commits? |
0535fb8
to
2b05f1a
Compare
Indeed,
done. |
2b05f1a
to
bc680a9
Compare
should probably be initialized as frozen, given no state modifications